Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postpone check of projects with blacklisted backend till there is no project in rate limit queue #888

Closed
Zlopez opened this issue Jan 27, 2020 · 0 comments · Fixed by #1025
Closed

Postpone check of projects with blacklisted backend till there is no project in rate limit queue #888

Zlopez opened this issue Jan 27, 2020 · 0 comments · Fixed by #1025
Labels
hacktoberfest Low Priority This ticket has a low priority type.feature New feature

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Jan 27, 2020 •
edited
Loading

Description

This is just a small enhancement that will make statistics much cleaner. Right now the projects are added to check queue after some time even if the project belongs to blacklisted backend. This enhancement propose to change the behavior to not include any project with blacklisted backend till all the projects, which were blocked by rate limit, were processed.

Requirements

  • Skip projects that are ready to check, but are part of the blacklisted backend, than we could remove the backend from blacklist as it is done right now. This way if we hit rate limit, it will be only with the projects that were in the rate limit queue before.

How this will make Anitya better

This will make any statictics much cleaner and the check will be much faster, because it will skip plenty of projects that will be skipped anyway.
@Zlopez Zlopez added type.feature New feature Low Priority This ticket has a low priority labels Jan 27, 2020
Zlopez added a commit to Zlopez/anitya that referenced this issue Feb 19, 2021
@Zlopez
Don't add projects with blacklisted backend to check queue
6a3bf04 
It doesn't make much sense to add projects from blacklisted backend to
check queue when they will be skipped anyway.

This will make run statistics make clearer and will add the projects that
were in the run when the backend was blacklisted to be checked first.

Closes fedora-infra#888

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue Feb 19, 2021
Merged
Zlopez added a commit that referenced this issue Feb 19, 2021
@Zlopez
Don't add projects with blacklisted backend to check queue
f4fa0a8 
It doesn't make much sense to add projects from blacklisted backend to
check queue when they will be skipped anyway.

This will make run statistics make clearer and will add the projects that
were in the run when the backend was blacklisted to be checked first.

Closes #888

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Low Priority This ticket has a low priority type.feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't add projects with blacklisted backend to check queue Zlopez/anitya
1 participant
@Zlopez