Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter field for versions #898

Closed
Zlopez opened this issue Apr 15, 2020 · 2 comments · Fixed by #944
Closed

Add filter field for versions #898

Zlopez opened this issue Apr 15, 2020 · 2 comments · Fixed by #944
Assignees
@Zlopez
Labels
groomed High priority This ticket has a high priority type.feature New feature
Milestone
1.0

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Apr 15, 2020 •
edited
Loading

Description

We should add filter field to versions, so we could prevent retrieving some of the versions. This field should prevent the versions containing matching string to be retrieved.

For example if filter is set to prefix, it will skip versions like prefix-5.5, 3.2.1-prefix and so on.

Requirements

  • Add field to project_new template with tooltip
  • Add method to BaseBackend that will filter the retrieved versions based on the project filter
  • Add column filter to Project, this column will be same as prefix
  • Call the new method in every backend before returning the versions
  • (Optional - only for admin) Add button that applies filter to existing project and removes every version that matches the filter

How this will make Anitya better

This will allow users to filter versions containing specific strings and lowers the number of flaged projects with versions for deletion.
@Zlopez Zlopez added type.feature New feature High priority This ticket has a high priority labels Apr 15, 2020
@Zlopez Zlopez added this to the 1.0 milestone Apr 15, 2020
@Zlopez Zlopez added the groomed label May 25, 2020
Zlopez added a commit to Zlopez/anitya that referenced this issue Jun 29, 2020
@Zlopez
Add filter field for versions
9f9661c 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez self-assigned this Jun 29, 2020
@Zlopez Zlopez mentioned this issue Jun 29, 2020
Merged
Zlopez added a commit to Zlopez/anitya that referenced this issue Jun 30, 2020
@Zlopez
Add filter field for versions
dfe7553 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Jul 1, 2020
@Zlopez
Add filter field for versions
e077f58 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Jul 2, 2020
@Zlopez
Add filter field for versions
cd68638 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue Jul 2, 2020
Closed
@Zlopez
Copy link
Contributor Author

Zlopez commented Jul 9, 2020

I'm closing this one in favor of #753

@Zlopez Zlopez closed this as completed Jul 9, 2020
@Zlopez
Copy link
Contributor Author

Zlopez commented Oct 27, 2020

After I thought about this for a while it could still be helpful. There are projects, that are tagging things that are not releases at all and this ticket will help to filter that.

@Zlopez Zlopez reopened this Oct 27, 2020
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 2, 2020
@Zlopez
Add filter field for versions
d86ec76 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 2, 2020
@Zlopez
Add filter field for versions
e5e1d2e 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 2, 2020
@Zlopez
Add filter field for versions
b4b79a7 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Update API v2 versions call
* Add button to apply filter for admins

Closes fedora-infra#898

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Dec 3, 2020
@Zlopez
Add filter field for versions
0debc0c 
* Add filter filed to project html template
* Add method for filtering to BaseBackend
* Call the above method on every backend
* Add column filter to Project
* Add migration for new column
* Change API call api/version/get to return empty list if no version is
  retrieved
* Update API v2 versions call
* Add button to apply filter for admins

Closes #898

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zlopez Zlopez

Labels
groomed High priority This ticket has a high priority type.feature New feature
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add filter field for versions Zlopez/anitya
1 participant
@Zlopez