Only include unyanked crate versions #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
|
|
Thanks for the PR! Could you check the failing test and add news file for this change? |
carlwgeorge
force-pushed
the
yanked_crates
branch
from
1ee39d0 to
43b56e8
Compare
|
Build succeeded.
|
crates.io allows maintainers to "yank" a crate. When this happens, the crates backend should not include the yanked version. https://doc.rust-lang.org/cargo/commands/cargo-yank.html
carlwgeorge
force-pushed
the
yanked_crates
branch
from
43b56e8 to
2a75b76
Compare
|
Build succeeded.
|
Zlopez
approved these changes
Jan 19, 2022
|
Hi @carlwgeorge ! Sorry for taking so long to reply, your email did not get lost :) Thanks for filing this PR, looks good from my side. I just have one question: Once a version has been added to the database, it won't get removed again, if it becomes "yanked" at some later point, will it? |
|
No, once anitya sees a version, it's saved even if it changes to yanked status later. But such a version can be flagged for removal by the admins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crates.io allows maintainers to "yank" a crate. When this happens, the crates backend should not include the yanked version.
https://doc.rust-lang.org/cargo/commands/cargo-yank.html