Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only included unyanked PyPI versions #1334

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Only included unyanked PyPI versions #1334

merged 2 commits into from
Jun 20, 2022

Conversation

carlwgeorge
Copy link
Contributor

pypi.org allows maintainers to "yank" a PyPI release. When this happens, the PyPI backend should not include the yanked version.

https://pypi.org/help/#yanked

@carlwgeorge carlwgeorge requested a review from a team as a code owner April 8, 2022 01:17
@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@Zlopez
Copy link
Contributor

Zlopez commented Apr 8, 2022

This looks like a good enhancement, but it introduces errors to existing tests. Could you look into it?

@carlwgeorge @Zlopez
Only included unyanked PyPI versions
7aa4911 
pypi.org allows maintainers to "yank" a PyPI release.  When this
happens, the PyPI backend should not include the yanked version.

https://pypi.org/help/#yanked
@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

✔️ fi-tox-mypy SUCCESS in 5m 14s
✔️ fi-tox-lint SUCCESS in 4m 15s
✔️ fi-tox-format SUCCESS in 4m 17s
❌ fi-tox-python38 FAILURE in 7m 40s
❌ fi-tox-python39 FAILURE in 7m 32s
❌ fi-tox-python310 FAILURE in 7m 38s
✔️ fi-tox-docs SUCCESS in 5m 16s
✔️ fi-tox-bandit SUCCESS in 4m 15s
❌ fi-tox-diff-cover FAILURE in 8m 11s

@Zlopez
Fix the failing tests
3ef3f67 
Not every version contains yanked field, let's reflect that in the code.

Signed-off-by: Michal Konečný <[email protected]>
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ fi-tox-mypy SUCCESS in 6m 02s
✔️ fi-tox-lint SUCCESS in 5m 07s
✔️ fi-tox-format SUCCESS in 3m 44s
✔️ fi-tox-python38 SUCCESS in 7m 20s
✔️ fi-tox-python39 SUCCESS in 7m 26s
✔️ fi-tox-python310 SUCCESS in 7m 38s
✔️ fi-tox-docs SUCCESS in 5m 06s
✔️ fi-tox-bandit SUCCESS in 3m 57s
✔️ fi-tox-diff-cover SUCCESS in 8m 13s

Zlopez
Zlopez approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything now works as expected

@mergify mergify bot merged commit 6effeee into fedora-infra:master Jun 20, 2022
@Zlopez Zlopez mentioned this pull request Jun 21, 2022
Closed
@carlwgeorge
Copy link
Contributor Author

Sorry I wasn't able to address this in a timely manner. Thanks for getting it resolved and merged.

@carlwgeorge carlwgeorge deleted the yanked_pypi branch June 27, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlopez Zlopez Zlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlwgeorge @Zlopez