Use the new url for CPAN, in https #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there is likely no practical issue, I suspect we should be cautious and not parse XML download in cleartext, given the rather large amount of issues with XML parsing in the past: https://www.owasp.org/index.php/XML_Security_Cheat_Sheet
jeremycline
added a commit
to mscherer/anitya
that referenced
this pull request
Jul 19, 2018
Signed-off-by: Jeremy Cline <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 89.51% 89.45% -0.06%
==========================================
Files 54 54
Lines 2556 2561 +5
Branches 327 327
==========================================
+ Hits 2288 2291 +3
- Misses 201 203 +2
Partials 67 67
Continue to review full report at Codecov.
|
jeremycline
force-pushed
the
update_cpan_url
branch
from
ff8d6b8 to
cb923f3
Compare
jeremycline
added a commit
to mscherer/anitya
that referenced
this pull request
Jul 19, 2018
Signed-off-by: Jeremy Cline <[email protected]>
We already depend on defusedxml (indirectly) so pull it in explicitly and use it for XML parsing. Additionally, more gracefully handle failures to split titles. This updates the HTTP recordings for metacpan. Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
jeremycline
force-pushed
the
update_cpan_url
branch
from
cb923f3 to
f93de62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there is likely no practical issue, I suspect we should be cautious
and not parse XML download in cleartext, given the rather large
amount of issues with XML parsing in the past:
https://www.owasp.org/index.php/XML_Security_Cheat_Sheet