Fix for cron issues #613
Merged
Fix for cron issues #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error was caused by trying to retrieve last version when no version was received
This will prevent issue with UnicodeEncodeError when running files/anitya_cron.py
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 90.02% 90.03% +0.01%
==========================================
Files 55 55
Lines 2646 2650 +4
Branches 341 343 +2
==========================================
+ Hits 2382 2386 +4
Misses 201 201
Partials 63 63
Continue to review full report at Codecov.
|
jeremycline
suggested changes
Sep 20, 2018
anitya/lib/backends/github.py
Outdated
| 'Project %s was incorrectly set-up. \ | ||
| Can\'t parse owner and repo' % project.name) | ||
| 'Project %s was incorrectly set-up. ' % project.name + | ||
| 'Can\'t parse owner and repo.') |
There was a problem hiding this comment.
It's neater to do it as:
"Project {} was incorrectly set-up. Can't parse owner and repo.".format(project.name)
rather than having the format in the middle of a string
jeremycline
reviewed
Sep 20, 2018
anitya/lib/backends/github.py
Outdated
| 'Project %s was incorrectly set-up. ' % project.name + | ||
| 'Can\'t parse owner and repo.') | ||
| """Project {} was incorrectly set-up. | ||
| Can\'t parse owner and repo.""".format(project.name)) |
There was a problem hiding this comment.
FYI you can do
raise AnityaPluginException(
"..."
"more text".format())
There was a problem hiding this comment.
Didn't know that, it can't be done with %.
jeremycline
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix current cron issues on staging.