Add towncrier #618
Add towncrier #618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 55 55
Lines 2650 2650
Branches 343 343
=======================================
Hits 2386 2386
Misses 201 201
Partials 63 63
Continue to review full report at Codecov.
|
docs/contributing.rst
Outdated
| * ``PR42`` when the change has been implemented in pull request ``42``, and | ||
| there is no associated issue | ||
| * ``Cabcdef`` when the change has been implemented in changeset ``abcdef``, and | ||
| there is no associated issue or pull request. |
There was a problem hiding this comment.
Since you use mergify and it rebases, I recommend against using commit hashes - the author won't be able to predict their hash, and so any hashes they use will lead to a 404 link.
There was a problem hiding this comment.
Yeah, you are right. I didn't noticed this.
docs/contributing.rst
Outdated
| * ``Cabcdef`` when the change has been implemented in changeset ``abcdef``, and | ||
| there is no associated issue or pull request. | ||
| * ``username`` for contributors (``author`` extention). It should be the | ||
| username part of their commits' email address. |
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
There was a problem hiding this comment.
I recommend adding a docblock that explains the purpose of this script and any args it accepts (if any).
There was a problem hiding this comment.
Most of the code is copied from fedora-infra/fedora-messaging#67.
But I will add it, so this is more readable.
| @@ -0,0 +1,19 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
There was a problem hiding this comment.
I didn't see a general Copyright claim on Anitya - I also recommend adding a copyright claim on this file.
No description provided.