Add migrations for new GitHub backend #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 56 56
Lines 2690 2690
Branches 352 352
=======================================
Hits 2425 2425
Misses 201 201
Partials 64 64Continue to review full report at Codecov.
|
elyscape
force-pushed
the
github-migration
branch
from
4247f71 to
f1d5648
Compare
jeremycline
reviewed
Oct 8, 2018
There was a problem hiding this comment.
Both these migrations look right to me, but I've not tested them on a database dump to make completely sure. I'll leave it up to @Zlopez to review and merge. Thanks for the PR!
|
I tried to test it, but right now I'm getting 404 when trying to receive database dump from production. So I need to wait until this will be fixed. |
|
The database is frozen now and the name of the dump is different, I changed it in ansible script and run it. It will be enough, if you could just add also the projects with |
Zlopez
requested changes
Oct 9, 2018
|
|
||
| def downgrade(): | ||
| """No-op, as empty version_url wouldn't have worked before anyway.""" | ||
| pass |
There was a problem hiding this comment.
Change to raise NotImplementedError
| SET version_url=trim(substr(homepage, 20), '/') | ||
| WHERE backend = 'GitHub' | ||
| AND homepage LIKE 'https://github.com/%' | ||
| AND version_url IS NULL |
| SET version_url=trim(substr(homepage, 19), '/') | ||
| WHERE backend = 'GitHub' | ||
| AND homepage LIKE 'http://github.com/%' | ||
| AND version_url IS NULL |
Zlopez
requested changes
Oct 9, 2018
|
|
||
|
|
||
| def downgrade(): | ||
| """Convert GitHub owner/project to URL to work with old GitHub backend.""" |
There was a problem hiding this comment.
This isn't necessery, the old backend can work with owner/repo in version_url.
|
I found out, I tried your migration script on wrong db dump. So I started again and found out, there is issue with the new dump, because it's missing all user related tables. |
The new GitHub backend expects that version_url will be an owner/project pair rather than a URL. Signed-off-by: Eli Young <[email protected]>
This uses the homepage field to populate any null version_url fields on projects that use the GitHub backend. Signed-off-by: Eli Young <[email protected]>
elyscape
force-pushed
the
github-migration
branch
from
f1d5648 to
ef2767f
Compare
|
@Zlopez Comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two database migrations to support the new GitHub backend, which expects that the
version_urlfield will be in the formatowner/project. The first migration converts any projects that have a URL in that field to the required format. The second migration uses the value of thehomepagefield to populate any projects that use the GitHub backend and have a null value for theversion_urlfield.