Add supported versions of python to setup script #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Konečný <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 56 56
Lines 2698 2698
Branches 354 354
=======================================
Hits 2456 2456
Misses 187 187
Partials 55 55Continue to review full report at Codecov.
|
jeremycline
reviewed
Oct 31, 2018
setup.py
Outdated
| @@ -62,6 +62,12 @@ def get_requirements(requirements_file='requirements.txt'): | |||
| license='GPLv2+', | |||
| download_url='https://fedorahosted.org/releases/a/n/anitya/', | |||
| url='https://fedorahosted.org/anitya/', | |||
| classifiers=[ | |||
| "Programming Language :: Python :: 2.7", | |||
There was a problem hiding this comment.
While Python 2.7 may still work, I wouldn't try to support it since we run 3 in production. I'd say supporting Python 3.6+ is reasonable (unless there's a nice API from 3.7 you want to use)
There was a problem hiding this comment.
You are right, the Python 2.7 shouldn't be there.
Signed-off-by: Michal Konečný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Konečný [email protected]