Upgrade vagrant to Fedora 29 #653
Conversation
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 56 56
Lines 2695 2695
Branches 354 354
=======================================
Hits 2452 2452
Misses 187 187
Partials 56 56Continue to review full report at Codecov.
|
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| - name: Apply database migrations | |||
| become_user: "{{ ansible_env.SUDO_USER }}" | |||
| command: ~/.virtualenvs/anitya/bin/alembic upgrade head | |||
| command: ~/.virtualenvs/anitya/bin/alembic upgrade heads | |||
There was a problem hiding this comment.
Why not just ensure there is only one head at a time so that your migration path is explicit? This is what I do in Bodhi.
There was a problem hiding this comment.
I need to look how is this checked in Bodhi. This was the first solution I came up with.
There was a problem hiding this comment.
Couldn't find where this is checked in Bodhi, but I created a head merge migration script #654
|
On Wed, 2018-11-07 at 01:24 -0800, Zlopez wrote:
Couldn't find where this is checked in Bodhi
|
|
This is the reason I didn't found it. I thought it is some check in pull request, but if this is only a test, I will add it to this PR. |
|
On Wed, 2018-11-07 at 19:22 +0000, Zlopez wrote:
I thought it is some check in pull request, but if this is only a
test, I will add it to this PR.
It would probably be more sensible to make it a PR check rather than a
unit test, but that's how it is in Bodhi for now. Now that Bodhi does
have separate checks, perhaps it would be good for me to split that out
into a separate type of test…
|
|
I added the test with last commit, but we should first merge #654 to fix the failing test. |
|
Rebased after merge of #654 |
Some things were changed: * virtualenv-3 is now virtualenv * sphinx version restriction was removed - 1.5.6 not working on python 3.7 * Add alembic tests Signed-off-by: Michal Konečný <[email protected]>
Some things were changed:
3.7
more migrations should be applied at once
Signed-off-by: Michal Konečný [email protected]