Refresh page after full check #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Konečný <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 57 57
Lines 2864 2864
Branches 391 391
=======================================
Hits 2744 2744
Misses 84 84
Partials 36 36Continue to review full report at Codecov.
|
cverna
reviewed
Dec 12, 2018
| @@ -281,6 +281,7 @@ <h3 class="panel-title"> | |||
| output = res.error; | |||
| } | |||
| $('#version_info').html("Latest versions: " + output); | |||
| window.location.reload(false); | |||
There was a problem hiding this comment.
Just out curiosity why is this needed ?
There was a problem hiding this comment.
This is a button on the page. If you click on it, it will do a regular check for new versions. This could change project in the database, but the page will still have old information. It's confusing for the user that used this button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Konečný [email protected]