Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example of usage #719

Merged
merged 7 commits into from
Feb 4, 2019
Merged

Added example of usage #719

merged 7 commits into from
Feb 4, 2019

Conversation

yarons
Copy link
Contributor

@yarons yarons commented Jan 31, 2019

As proposed by @Zlopez

Thanks!

Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing, otherwise looking good.

Zlopez
Zlopez previously approved these changes Jan 31, 2019
Co-Authored-By: yarons <[email protected]>
@Zlopez
Copy link
Contributor

Zlopez commented Jan 31, 2019

I noticed you approved my change, so now you have two black lines above and bellow the example. :-D Could you fix this.

Silly me :)

Thanks again!
@Zlopez
Copy link
Contributor

Zlopez commented Feb 1, 2019

I will merge this after #720 which is fixing the tests.

@codecov-io
Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          58       58           
  Lines        3041     3041           
  Branches      392      392           
=======================================
  Hits         2939     2939           
  Misses         64       64           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d72f4...1f0c92e. Read the comment docs.

@mergify mergify bot merged commit 4f8938e into fedora-infra:master Feb 4, 2019
@yarons yarons deleted the patch-2 branch February 4, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants