Fix URL to fedmsg website on index.html #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cverna
previously approved these changes
Feb 4, 2019
Zlopez
requested changes
Feb 4, 2019
There was a problem hiding this comment.
Could you please add news file for towncrier? For guidelines look here - https://anitya.readthedocs.io/en/latest/contributing.html#release-notes
Conan-Kudo
force-pushed
the
fix-fedmsg-site-url
branch
from
9c1817d to
920f7be
Compare
|
@Zlopez Done. |
Conan-Kudo
force-pushed
the
fix-fedmsg-site-url
branch
from
920f7be to
4851c5d
Compare
Zlopez
previously approved these changes
Feb 4, 2019
|
There is one test failing after your change. Could you look at it? |
|
@Zlopez I didn't change any Python code, so I have no idea what's going on here. |
|
Oh wait, I see what's wrong. Let me fix... |
The domain fedmsg.com is not owned by the Fedora Project and points to some kind of spam site. The page on readthedocs.io appears to be the correct project website, so we should point to that. Signed-off-by: Neal Gompa <[email protected]>
Conan-Kudo
force-pushed
the
fix-fedmsg-site-url
branch
from
4851c5d to
06eea65
Compare
|
@Zlopez Should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 58 58
Lines 3041 3041
Branches 392 392
=======================================
Hits 2939 2939
Misses 64 64
Partials 38 38Continue to review full report at Codecov.
|
Zlopez
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain fedmsg.com is not owned by the Fedora Project and points
to some kind of spam site. The page on readthedocs.io appears to be
the correct project website, so we should point to that.
Signed-off-by: Neal Gompa [email protected]