Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build testing to Travis #799

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Add docker build testing to Travis #799

merged 1 commit into from
Aug 14, 2019

Conversation

abitrolly
Copy link
Contributor

As a followup to #798 I decided to test if Docker build is still operational, continuously.

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          59       59           
  Lines        3141     3141           
  Branches      401      401           
=======================================
  Hits         3043     3043           
  Misses         59       59           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5242233...a52564f. Read the comment docs.

@Zlopez
Copy link
Contributor

Zlopez commented Aug 2, 2019

Dockerfile is really outdated, so I'm not sure if the Anitya in docker will run at all.

pypingou
pypingou previously approved these changes Aug 2, 2019
@abitrolly
Copy link
Contributor Author

@pypingou it is not ready yet. I am going to make proper stages, so the test will fail faster on improper linting etc.

@abitrolly
Copy link
Contributor Author

@pypingou ready to be merged.

@Zlopez
Copy link
Contributor

Zlopez commented Aug 2, 2019

@abitrolly Could you squash the commits and add news file?
See https://anitya.readthedocs.io/en/stable/contributing.html#release-notes

@abitrolly
Copy link
Contributor Author

@Zlopez done.

Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better in Travis. Thanks for your work :-)

@abitrolly
Copy link
Contributor Author

@Zlopez Zlopez merged commit 1a1686c into fedora-infra:master Aug 14, 2019
@abitrolly abitrolly deleted the patch-1 branch August 14, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants