Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #816

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Minor cleanup #816

merged 4 commits into from
Aug 27, 2019

Conversation

vfazio
Copy link
Contributor

@vfazio vfazio commented Aug 26, 2019

Couple of changes to cleanup the Manifest file for deprecated files and update the gitignore for common directories

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files          61       61           
  Lines        3635     3635           
  Branches      485      485           
=======================================
  Hits         3535     3535           
  Misses         60       60           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ceae3...a44271e. Read the comment docs.

Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you add News file?

You can look here to see how.

vfazio added 3 commits August 27, 2019 09:02
Exclude common virtualenv names

Add exclusion for .vscode

Signed-off-by: Vincent Fazio <[email protected]>
Signed-off-by: Vincent Fazio <[email protected]>
Signed-off-by: Vincent Fazio <[email protected]>
@vfazio vfazio force-pushed the vfazio-minor-fixes branch from a44271e to c52f7af Compare August 27, 2019 14:02
@mergify mergify bot merged commit b23c889 into fedora-infra:master Aug 27, 2019
@vfazio vfazio deleted the vfazio-minor-fixes branch August 27, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants