Createdb.py fixes #817
Createdb.py fixes #817
Conversation
Completely rewrite the createdb.py script to create all of the proper schema necessary to get an instance up and running. This will correctly generate the social_auth tables and stamp the alembic version if an alembic config is specified. Signed-off-by: Vincent Fazio <[email protected]>
Previously, if the Anitya package was installed, alembic would use the package's migration script path for creating a revision. This would also fail since the revision mako script was not included in the package's manifest. Alembic will now use the local migration path. Signed-off-by: Vincent Fazio <[email protected]>
The database init code in lib/utilities was deprecated in 0.12. The only user of it was createdb.py and that has now been rewritten completely. Signed-off-by: Vincent Fazio <[email protected]>
|
This pull request introduces 5 alerts when merging f657aa3 into f9ceae3 - view on LGTM.com new alerts:
Warning - Automated code review for release-monitoring/anitya will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
|
This pull request fixes 1 alert when merging 5096f3a into f9ceae3 - view on LGTM.com fixed alerts:
Warning - Automated code review for release-monitoring/anitya will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Signed-off-by: Vincent Fazio <[email protected]>
vfazio
force-pushed
the
vfazio-createdb-fixes
branch
from
5096f3a to
1593835
Compare
|
This pull request fixes 1 alert when merging 1593835 into f9ceae3 - view on LGTM.com fixed alerts:
Warning - Automated code review for release-monitoring/anitya will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Signed-off-by: Vincent Fazio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 97.24% 97.24% -0.01%
==========================================
Files 61 61
Lines 3635 3631 -4
Branches 485 485
==========================================
- Hits 3535 3531 -4
Misses 60 60
Partials 40 40
Continue to review full report at Codecov.
|
|
Thanks for the contribution 👍 |
|
This should help with #798 a bit I think |
|
This pull request fixes 1 alert when merging 4ab5b84 into f9ceae3 - view on LGTM.com fixed alerts:
Warning - Automated code review for release-monitoring/anitya will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Fix createdb.py so that it creates the proper tables, including the social_auth tables. Stamp the alembic revision head if a config is provided.
Drop the old DB init code as it's stale.