Only check status_code if call_url returns response

anitya/lib/backends/__init__.py

@@ -326,11 +326,11 @@ def get_versions_by_regex(url, regex, project, insecure=False):
             'Could not call : "%s" of "%s", with error: %s'
             % (url, project.name, str(err))
         )
-    # Not modified
-    if req.status_code == 304:
-        return []
 
     if not isinstance(req, six.string_types):
+        # Not modified
+        if req.status_code == 304:
+            return []
         req = req.text
 
     return get_versions_by_regex_for_text(req, url, regex, project)

anitya/tests/lib/backends/test_init.py

@@ -159,7 +159,7 @@ class GetVersionsByRegexTests(unittest.TestCase):
     @mock.patch("anitya.lib.backends.BaseBackend.call_url")
     def test_get_versions_by_regex_not_modified(self, mock_call_url):
         """Assert that not modified response is handled correctly."""
-        mock_response = mock.Mock()
+        mock_response = mock.Mock(spec=object)
         mock_response.status_code = 304
         mock_call_url.return_value = mock_response
         mock_project = mock.Mock()
@@ -168,6 +168,20 @@ def test_get_versions_by_regex_not_modified(self, mock_call_url):
 
         self.assertEqual(versions, [])
 
+    @mock.patch("anitya.lib.backends.BaseBackend.call_url")
+    def test_get_versions_by_regex_string_response(self, mock_call_url):
+        """Assert that string response is handled correctly."""
+        mock_call_url.return_value = ""
+        mock_project = mock.Mock()
+
+        self.assertRaises(
+            AnityaPluginException,
+            backends.get_versions_by_regex,
+            "url",
+            "regex",
+            mock_project,
+        )
+
 
 class GetVersionsByRegexTextTests(unittest.TestCase):
     """

news/PR833.bug

@@ -0,0 +1 @@
+Crash when calling FTP url