Mock the Fedora Messaging calls in the unit tests #860
Conversation
|
Could you fix the formatting issue? And could you add news file for this change |
On it, this unblocks a couple other PRs whose CI tests fail. |
nphilipp
force-pushed
the
mock-fm-in-unit-tests
branch
2 times, most recently
from
f4a9683 to
cfcb418
Compare
This should make the tests much faster since they won't wait for the publish timeout anymore. Signed-off-by: Aurélien Bompard <[email protected]>
Just for completeness sake... Signed-off-by: Nils Philippsen <[email protected]>
|
It looks like some of the mocks are still missing. |
|
I've come across a couple of places where messaging calls still need to be mocked out. Stay tuned. |
nphilipp
force-pushed
the
mock-fm-in-unit-tests
branch
from
cfcb418 to
2de1f16
Compare
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 61 61
Lines 3674 3674
Branches 497 497
=======================================
Hits 3576 3576
Misses 58 58
Partials 40 40Continue to review full report at Codecov.
|
|
@Mergifyio refresh |
|
Command Hey, I reacted but my real name is @Mergifyio |
This should make the tests much faster since they won't wait for the publish timeout anymore.