Link to commit of latest version if known #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nphilipp
force-pushed
the
master--github.ghproxy.topmit-url
branch
from
d249a23 to
de07fe5
Compare
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
+ Coverage 97.03% 97.07% +0.03%
==========================================
Files 61 61
Lines 3577 3587 +10
Branches 512 512
==========================================
+ Hits 3471 3482 +11
Misses 64 64
+ Partials 42 41 -1
Continue to review full report at Codecov.
|
nphilipp
force-pushed
the
master--github.ghproxy.topmit-url
branch
3 times, most recently
from
3499676 to
354c14f
Compare
nphilipp
force-pushed
the
master--github.ghproxy.topmit-url
branch
2 times, most recently
from
cf1b4d5 to
cd55786
Compare
Zlopez
requested changes
Jan 6, 2020
nphilipp
force-pushed
the
master--github.ghproxy.topmit-url
branch
2 times, most recently
from
575b60d to
29baad0
Compare
|
Hmm, there are two failures flagged by Travis CI:
I'll force push again to see if the #1008.6 issue improves, there's nothing I can do about the latter. |
- Add ProjectVersion.commit_url This is to let us store URLs pointing to tagged commits. - GitHub: Store received commit URLs for versions - Set commit_url on version objects - Add Project.latest_version_object property Fixes: fedora-infra#590 Signed-off-by: Nils Philippsen <[email protected]>
nphilipp
force-pushed
the
master--github.ghproxy.topmit-url
branch
from
29baad0 to
1ec5e62
Compare
|
@nphilipp 3.8 could be safely ignored |
Zlopez
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only links the commit from the latest version field, where we can make it explicit that it's a commit, not a release page or anything: