Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate project search form #877

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Do not duplicate project search form #877

merged 2 commits into from
Jan 6, 2020

Conversation

abitrolly
Copy link
Contributor

Currently search form for projects present both in page header and in results table header. This PR leaves search form in table header only when searching inside distros.

@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          61       61           
  Lines        3697     3697           
  Branches      499      499           
=======================================
  Hits         3598     3598           
  Misses         58       58           
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 208822c...7b4410d. Read the comment docs.

Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things:

  • Format should not be only targeted on diff
  • Add news file
  • Squash commits

@abitrolly
Copy link
Contributor Author

Squashed, moved black to another PR and added new fragment.

@abitrolly abitrolly requested a review from Zlopez January 6, 2020 11:55
@mergify mergify bot merged commit c721b8b into fedora-infra:master Jan 6, 2020
@abitrolly abitrolly deleted the patch-1 branch January 6, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants