Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing projects in GitLab subgroups #884

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

nphilipp
Copy link
Member

@nphilipp nphilipp commented Jan 9, 2020

In GitLab API endpoints, subgroups are separated from parent
(sub-)groups with URL-encoded slashes, i.e. %2F.

Fixes: #763

Signed-off-by: Nils Philippsen [email protected]

@nphilipp nphilipp added this to the 0.18.0 milestone Jan 9, 2020
In GitLab API endpoints, subgroups are separated from parent
(sub-)groups with URL-encoded slashes, i.e. %2F.

Fixes: fedora-infra#763

Signed-off-by: Nils Philippsen <[email protected]>
@nphilipp nphilipp force-pushed the master--gitlab-subgroups branch from 1fda3cc to 9fff3f5 Compare January 9, 2020 16:29
@nphilipp nphilipp requested a review from Zlopez January 9, 2020 16:30
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks easy and it's fixing the issue 👍

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #884 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   97.03%   97.07%   +0.03%     
==========================================
  Files          61       61              
  Lines        3577     3587      +10     
  Branches      512      512              
==========================================
+ Hits         3471     3482      +11     
  Misses         64       64              
+ Partials       42       41       -1
Impacted Files Coverage Δ
anitya/lib/utilities.py 94.44% <ø> (ø) ⬆️
anitya/lib/backends/github.py 100% <100%> (+0.87%) ⬆️
anitya/db/models.py 100% <100%> (ø) ⬆️
anitya/lib/versions/base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fff3f5...9a57936. Read the comment docs.

@mergify mergify bot merged commit a0e5658 into fedora-infra:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mishandling some Gitlab URL
3 participants