Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add admin guide for release-monitoring.org #964

Merged
merged 2 commits into from
Sep 23, 2020
Merged

add admin guide for release-monitoring.org #964

merged 2 commits into from
Sep 23, 2020

Conversation

luto
Copy link
Contributor

@luto luto commented Sep 21, 2020

As discussed in IRC :)

Longer description will follow.

Zlopez
Zlopez reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two other things:

  1. Add the document to index page - I want to have two sections in the future User guide and Admin user guide
  2. Add news file - see contribution guidelines

@luto
Copy link
Contributor Author

luto commented Sep 22, 2020

fixed the comments and rebased onto newest master.

@luto luto marked this pull request as ready for review September 22, 2020 22:14
@luto luto requested a review from a team as a code owner September 22, 2020 22:14
@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #964 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          65       65           
  Lines        3852     3852           
  Branches      560      560           
=======================================
  Hits         3733     3733           
  Misses         71       71           
  Partials       48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3145d5...f6742df. Read the comment docs.

Zlopez
Zlopez requested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more change and we are ready for merge

luto added 2 commits September 23, 2020 18:49
@luto
Add admin guide for release-monitoring.org
1965b43 
The new document aims to make handling of flags and other reports on
release-monitoring.org more consistent by providing a set of
guidelines. They are designed to mirror the current best-effort
mode of operation and rely heavily on common sense of the reader.
@luto
Add new admin guide to NEWS
f6742df
@mergify mergify bot merged commit fab64d3 into fedora-infra:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlopez Zlopez Zlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luto @Zlopez