fix(java): Line up protobuf type handling with our other generators #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
reviewed
Mar 6, 2025
| @@ -183,7 +183,7 @@ public String visitLong() { | |||
|
|
|||
| @Override | |||
| public String visitUint() { | |||
| return "Long"; | |||
| return "Integer"; | |||
There was a problem hiding this comment.
I wonder if we should name this distinct even though it still maps to an int. That way if a user has an undiscriminated union with both there's no conflict. Otherwise the following type would have two things named with Integer:
types:
Number:
discriminated: false
union:
- uint
- integerThere was a problem hiding this comment.
Ah ignore me, I was thinking this would be used in the union generator, but this detail likely isn't relevant for Java!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using longs for uints, when we should have been using ints