http retrieve entire piece (not just CAR file) #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Jul 7, 2022
Comment on lines
200
to
+203
| content, err := s.getPieceContent(ctx, pieceCid) | ||
| if err == nil && isCar { | ||
| content, err = s.getCarContent(pieceCid, content) | ||
| } |
There was a problem hiding this comment.
Aren't getPieceContent and getCarContent expensive operations? Shouldn't we do one or the other, but not override content when isCar == true ?
There was a problem hiding this comment.
In this case content is an io.ReadSeeker
getPieceContent gets a reader over the unsealed piece.
if isCar == true then getCarContent figures out the size of the CAR file by asking the DAG store for the max offset of the CAR index. If the DAG store doesn't have the index, getCarContent creates the index on the fly. Once it has the max offset, it just wraps the piece reader with a limit reader so that it only serves the CAR file.
|
🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To retrieve a piece:
http://localhost:7777/piece/<piece cid>To retrieve a CAR:
http://localhost:7777/piece/<piece cid>.car