Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update network skeleton docs #12631

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Oct 23, 2024

Proposed Changes

Updates Docs to include the reference to the PRs to the latest network skeleton upgrade (24).

cc @rjan90

Also there were two Filecoin-FFI section, so I removed one of those, lmk if I'm wrong.

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the duplicate filecoin-ffi section. I assume that was me... Thanks for fixing.

I'll let @rjan90 respond on if there is any reason not to update the doc to point to nv24 (more recent) example than the nv23 one. I'm not aware of reason, but I think it would come down to if nv24 steps didn't follow the desired process for some reason.

@kamuik16
Copy link
Contributor Author

Good catch on the duplicate filecoin-ffi section. I assume that was me... Thanks for fixing.

I'll let @rjan90 respond on if there is any reason not to update the doc to point to nv24 (more recent) example than the nv23 one. I'm not aware of reason, but I think it would come down to if nv24 steps didn't follow the desired process for some reason.

I had done the complete nv24 skeleton upgrade by following all the steps only, but happy to wait for @rjan90 approval.

Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@rjan90 rjan90 merged commit c6fdf95 into filecoin-project:master Oct 24, 2024
82 checks passed
@kamuik16 kamuik16 deleted the kamui branch October 24, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants