Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): shift chainindex validate-backfill command #12668

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat(cli): shift chainindex validate-backfill command #12668

merged 2 commits into from
Nov 7, 2024

Conversation

virajbhartiya
Copy link
Member

Related Issues

Closes #12654

Proposed Changes

Shift the chainindex command from lotus-shed into lotus-cli

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@virajbhartiya
Copy link
Member Author

The TestOnboardRawPieceVerified_WithActorEvents that is failing in the CI is passing locally

rvagg
rvagg approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks good, simpler than I imagined too.

@aarshkshah1992
Copy link
Contributor

nice lgtm

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Nov 7, 2024
@rvagg rvagg merged commit f0f5c76 into filecoin-project:master Nov 7, 2024
80 of 82 checks passed
@virajbhartiya virajbhartiya deleted the lotus-index branch November 7, 2024 07:56
@rvagg rvagg mentioned this pull request Nov 29, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChainIndexer: move lotus-shed chainindex into lotus CLI
3 participants
@virajbhartiya @aarshkshah1992 @rvagg