feat: init SwiftUI library for FirebaseAuthSwiftUI #1237
Conversation
| func onCredentialReceived(_ credential: AuthCredential) | ||
| func onCredentialLinked(_ credential: AuthCredential) | ||
| // func onMFARequired(_ resolver: MultiFactorResolver) | ||
| } |
There was a problem hiding this comment.
Since we're targeting this toward SwiftUI users, what do you think of adding a @StateObject that tracks the auth state so consumers can use it directly instead of having to set up their own wrapper? This could be the auth provider itself or a separate object that's managed by the auth provider, or a default implementation of the AuthListenerProtocol.
There was a problem hiding this comment.
Hey @morganchen12 - sorry for the lates response, I was on holiday last week, and this week I wanted something more concrete to show you so we can agree on top level API design/flow. I still need to refactor a few things, but I'm hoping by the end of the day tomorrow I can provide how it works and see if you think it is reasonable. Also - agree on the point of having some form of a state object the user can consume for auth events 👍
|
|
||
| public init(configuration: AuthPickerViewConfiguration = AuthPickerViewConfiguration()) { | ||
| public init(configuration: AuthPickerViewConfiguration = AuthPickerViewConfiguration(), |
There was a problem hiding this comment.
The configuration would probably be either a view modifier, or better yet, a style.
| public var frameWidth: CGFloat | ||
| public var frameHeight: CGFloat | ||
|
|
||
| public init(warningMessage: String = "Incorrect email address", |
There was a problem hiding this comment.
All of these should be view modifiers.
| } | ||
|
|
||
| public class EmailAuthButtonConfiguration { | ||
| public var buttonText: String |
There was a problem hiding this comment.
In SwiftUI, you configure views by using view modifiers. They allow for a much more scalable configuration of views.
| @EnvironmentObject var authFUI: FUIAuth | ||
|
|
||
| public var body: some View { | ||
| if invalidEmailWarning { |
There was a problem hiding this comment.
This will break view identity - see https://swiftwithmajid.com/2021/12/09/structural-identity-in-swiftui/
Work in progress, no functionality at the moment. Just setting up the project:
FirebaseAuthSwiftUI(this has some basic types/class which will be needed later) &FirebaseAuthEmailSwiftUIfor email provider functionality.samples/swiftuiwhich pulls in the above libraries for developing.