Firestore: Remove vestigial mentions of STLport #14348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
force-pushed
the
dconeybe/STLPortVestigialArtifactsRemoval
branch
from
eb76079 to
7f68ee6
Compare
cherylEnkidu
approved these changes
Jan 23, 2025
jonsimantov
reviewed
Feb 11, 2025
| #endif | ||
|
|
||
| #else // !defined(__ANDROID__) | ||
| // On any other supported platform, just take Abseil's word for it. | ||
| #include "absl/base/config.h" |
There was a problem hiding this comment.
This changes things so that absl/base/config.h is included on Android, which breaks the C++ SDK's Android CI.
There was a problem hiding this comment.
Oops. Ok I'll fix this. Apologies.
There was a problem hiding this comment.
@jonsimantov Is the ndk floor r18 now, or is it still r16b?
nevermind
There was a problem hiding this comment.
@jonsimantov PTAL at this fix: #14442
There was a problem hiding this comment.
Thanks for the quick fix. And yeah we use r21e now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some vestigial cruft pertaining to STLPort, whose support was dropped in July 2021 (3.5 years ago at the time of writing) in firebase/firebase-cpp-sdk#510.
#no-changelog