Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imbalanced spacing in marker chart stack radio button row #4580

Closed
mstange opened this issue Apr 18, 2023 · 1 comment · Fixed by #4581
Closed

Imbalanced spacing in marker chart stack radio button row #4580

mstange opened this issue Apr 18, 2023 · 1 comment · Fixed by #4581

Comments

@mstange
Copy link
Contributor

mstange commented Apr 18, 2023

Screenshot 2023-04-18 at 11 54 24 AM

There's not enough space after "Filter stacks:", or too much space before each radio button label.

We don't have a "Filter stacks:" label in the call tree or the flame graph tab. Maybe we can remove it on the marker chart as well?

@julienw
Copy link
Contributor

julienw commented Apr 18, 2023

I added this label because I felt like that in the marker chart and table, we were lacking context for these radio buttons, so I quite strongly prefer to keep it.
But I agree that the space could be tweaked :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants