Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer column widths should allow for longer websites an emails #236

Closed
dakira opened this issue May 5, 2015 · 4 comments
Closed

Footer column widths should allow for longer websites an emails #236

dakira opened this issue May 5, 2015 · 4 comments
Labels
bug

Comments

@dakira
Copy link
Contributor

dakira commented May 5, 2015

This happens with the current HEAD.

breaking

In the best case the optimal widths should be calculated.
@Schrank
Copy link
Member

Schrank commented May 5, 2015

it is only line broken by a space :)

@Schrank Schrank added the bug label May 5, 2015
@dakira
Copy link
Contributor Author

dakira commented May 5, 2015

@Schrank the columns are "soft-wrapped" which works if you have multiple words. With one word (as in websites and emails) the soft-wrapping causes a line-break.

sprankhub added a commit that referenced this issue May 6, 2015
@sprankhub
[~BUGFIX] break lines on whitespaces and dashes, #236
21b2525
@sprankhub
Copy link
Member

Could you please have a look at the solution above? Do you think this is a good idea? Does it work for you?

Currently, we only break lines on whitespaces. Now we also break lines on dashes. I think this is the way to go.

@sprankhub
Copy link
Member

I merged the branch into the development branch and assume this is fixed.

Schrank added a commit that referenced this issue May 30, 2015
@Schrank
Merge branch 'development' into feature/182
b74f99e 
* development:
  fix missing translate attributes
  add all translations from XML files
  fixed Magento version in travis config
  added travis image to readme, fixes #228
  added travis configuration file, #228
  cleaned up german translation file and added missing strings
  ordered translation by name
  [~BUGFIX] break lines on whitespaces and dashes, #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Schrank @dakira @sprankhub