fix coinbase payment edge case #478
Merged
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When the coinbase address is the fee recipient, we exclusively use fee_recipient_balance_diff
since this is the value used by validation nodes
Using fee_recipient_balance_diff may cause block validation failures in certain edge cases
Real Example: If the fee recipient is a contract that sweeps its balance to another address on each call,
and we include a bundle paying directly to coinbase, the fee recipient balance would be 0 causing validation nodes to reject the block
💡 Motivation and Context
✅ I have completed the following steps:
make lint
make test