Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coinbase payment edge case #478

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix coinbase payment edge case #478

merged 1 commit into from
Mar 10, 2025

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Mar 10, 2025

📝 Summary

When the coinbase address is the fee recipient, we exclusively use fee_recipient_balance_diff
since this is the value used by validation nodes

Using fee_recipient_balance_diff may cause block validation failures in certain edge cases

Real Example: If the fee recipient is a contract that sweeps its balance to another address on each call,
and we include a bundle paying directly to coinbase, the fee recipient balance would be 0 causing validation nodes to reject the block

💡 Motivation and Context


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@dvush dvush requested review from ZanCorDX and ferranbt as code owners March 10, 2025 12:47
@ZanCorDX ZanCorDX merged commit df005d3 into develop Mar 10, 2025
4 checks passed
@ZanCorDX ZanCorDX deleted the fix_payment_to_coinbase branch March 10, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants