Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpaas: enable drivers for lx2160a-clearfog #1279

Closed
wants to merge 1 commit into from
Closed

dpaas: enable drivers for lx2160a-clearfog #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...tainer/src/third_party/coreos-overlay/sys-kernel/coreos-modules/files/arm64_defconfig-6.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,10 @@ CONFIG_USB_ULPI=y
CONFIG_USB_XHCI_PLATFORM=y
CONFIG_VIRTUALIZATION=y
CONFIG_XGENE_DMA=y
# EXTRA CONFIG FOR DPAA2
CONFIG_FSL_DPAA2_ETH=y
CONFIG_FSL_DPAA2_ETH_DCB=y
CONFIG_FSL_DPAA2_PTP_CLOCK=y
CONFIG_PTP_1588_CLOCK_QORIQ=y
CONFIG_FSL_MC_BUS=y
CONFIG_FSL_MC_UAPI_SUPPORT=y
Comment on lines +99 to +105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build failed with a following message:

 * ERROR: sys-kernel/coreos-modules-6.1.58::coreos failed (configure phase):
 *   Requested options not enabled in build:
 *     CONFIG_FSL_DPAA2_ETH
 *     CONFIG_FSL_DPAA2_ETH_DCB
 *     CONFIG_FSL_DPAA2_PTP_CLOCK
 *     CONFIG_FSL_MC_BUS
 *     CONFIG_FSL_MC_UAPI_SUPPORT
 *     CONFIG_PTP_1588_CLOCK_QORIQ

This usually means that some of these configs depend on something that was not enabled (either explicitly through our configs or implicitly by selected by some other enabled config or something). From what I have tracked these are the configs that dpaa2 requires directly or indirectly:

FSL_DPAA2_ETH
FSL_DPAA2_ETH_DCB
FSL_DPAA2_PTP_CLOCK
PTP_1588_CLOCK_QORIQ
FSL_MC_BUS
FSL_MC_UAPI_SUPPORT
FSL_MC_DPIO
DCB
PTP_1588_CLOCK
NET
POSIX_TIMERS
OF
ARCH_NXP
ARCH_LAYERSCAPE

From those, DCB and NET are already enabled in commonconfig. POSIX_TIMERS, PTP_1588_CLOCK are (implicitly?) enabled for both arm64 and amd64, and OF for arm64. You can see the final configs used for the kernel in our bincache: amd64, arm64).

This would mean that FSL_MC_DPIO, ARCH_NXP and ARCH_LAYERSCAPE are missing from arm64 config. Also, please keep the file sorted (you can use the sort_config.sh script which is in the same directory as the configs you modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for the review. The initial configs were taken from a 5.10 Ubuntu, and the 6.1 does not have some of those anymore, trying now to see which ones are which, as for example, Flatcar latest stable has the 5.15 and the latest alpha has 6.1, and thus need to be different. What I am trying to fix is support for the DPAA2 network drivers for Layerscale LX2160A using PXE boot via the u-boot bootloader (somewhat exotic in nature). This commit is a working one ader1990@23a078a, rebased on latest stable -> flatcar-3602 branch.

I will need to update the above commit for the 6.1, work in progress.

Thank you.