Update plugin.prettyurls.php for handling „“ #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use prettyurls in pretty-mode and if I use some special chars like „“ in title prettyurls generates broken urls. So I fixed it with a special preg_replace. You can name some more fixes within.
|
If I understand correctly the fix, maybe the correct place to handle this special case is the sanitize_title() function, isn't it? |
|
Maybe... I will have a look at this but I think it did not work for me in sanitize_title() function. |
|
Not a problem of the PrettyUrl plugin, but of the FP core itself. Fixed with 9f610dd - thanks for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use prettyurls in pretty-mode and if I tryed some special chars like „“ in title prettyurls generated broken urls. So I fixed it with a special preg_replace.
You can name some more fixes within (lines 83 AND 151!).