Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Feature: Propagate scheduleUpdate through nested poppers #121

Closed
tyscorp opened this issue Apr 2, 2018 · 6 comments
Closed

Feature: Propagate scheduleUpdate through nested poppers #121

tyscorp opened this issue Apr 2, 2018 · 6 comments

Comments

@tyscorp
Copy link

tyscorp commented Apr 2, 2018

When scheduleUpdate is called on a popper, it should call scheduleUpdate on all nested poppers. We can do this through context so it works through portals, too.

I'd be happy to take this on.

This would fix this issue: palantir/blueprint#2031

@FezVrasta
Copy link
Member

I'd ask you to hold on on this feature because we are going to replace the API completely in the next few days (see #117).

Anyway it's a good idea.

@tyscorp
Copy link
Author

tyscorp commented Apr 2, 2018

I could perhaps base my PR on the react-16-major-rewrite branch so we could get it into v1.0.0.

@FezVrasta
Copy link
Member

I'm not sure if we are going to use that specific API or a mixture of the first iteration and the last one.

@FezVrasta
Copy link
Member

The new API is now on beta and merged to master, please feel free to contribute on the new code base with your idea.

@tyscorp
Copy link
Author

tyscorp commented Apr 4, 2018

Ok, I'll need about 1 day I think. When is v1.0.0 set to release?

@FezVrasta
Copy link
Member

I'm waiting few days to receive feedbacks, if everything is fine I'll release it then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants