Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover2] Popovers don't update nested popovers' position when updated #2031

Closed
tyscorp opened this issue Jan 24, 2018 · 2 comments
Closed

[Popover2] Popovers don't update nested popovers' position when updated #2031

tyscorp opened this issue Jan 24, 2018 · 2 comments
Labels
Package: core Resolution: aged away Type: enhancement

Comments

@tyscorp
Copy link
Contributor

tyscorp commented Jan 24, 2018 •
edited
Loading

When a Popover's position is updated, scheduleUpdate needs to be called on all children Popovers.

This can be solved similarly to this issue.
@giladgray
Copy link
Contributor

@tyscorp sure thing! interested in submitting a PR?

@tyscorp tyscorp mentioned this issue Apr 2, 2018
Closed
@giladgray
Copy link
Contributor

giladgray commented Sep 28, 2018 •
edited
Loading

@tyscorp is this issue still relevant? we've upgraded popper.js several times and now invoke scheduleUpdate when target or content are resized (#2718 & #2745).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: core Resolution: aged away Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyscorp @giladgray @adidahiya