Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli, mrepl): support windows in marine cli and mrepl #406

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat(cli, mrepl): support windows in marine cli and mrepl #406

merged 2 commits into from
Jan 10, 2024

Conversation

ValeryAntopol
Copy link
Collaborator

@ValeryAntopol ValeryAntopol commented Jan 8, 2024 •
edited
Loading

Fixed build on Windows for both marine and mrepl cli tools, tested it on simple examples.

Please note that mrepl uses rustyline crate and inherits its limitations (copy-paste from repo readme):

Supported Platforms

  • Unix (tested on FreeBSD, Linux and macOS)
  • Windows
    • cmd.exe
    • Powershell

Note:

  • Powershell ISE is not supported, check Powershell ISE kkawakam/rustyline#56
  • Mintty (Cygwin/MinGW) is not supported
  • Highlighting / Colors are not supported on Windows < Windows 10 except with ConEmu and ColorMode::Forced.

monoid
monoid reviewed Jan 8, 2024
View reviewed changes
monoid
monoid approved these changes Jan 8, 2024
View reviewed changes
Copy link

@monoid monoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fluencebot fluencebot added the e2e Run e2e workflow label Jan 8, 2024
@ValeryAntopol ValeryAntopol merged commit 71d1fb1 into master Jan 10, 2024
@ValeryAntopol ValeryAntopol deleted the feat/support-windows branch January 10, 2024 12:37
@fluencebot fluencebot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monoid monoid monoid approved these changes

@mikevoronov mikevoronov Awaiting requested review from mikevoronov

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValeryAntopol @monoid @fluencebot