-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share_plus): SharePlus refactor #3404
base: main
Are you sure you want to change the base?
Conversation
One last big piece missing is the Windows refactor, which I plan to do tomorrow or so. Then I'll write up a migration guide on the README.md. The API and functionality is still backwards compatible, but just getting deprecated warnings. The old The
|
I will review this again later tonight and merge if everything looks ok still |
Description
This PR contains several improvements on the share_plus package:
SharePlus
class viainstance
singleton, rather than using static methods.SharePlatform
for testing.subject
andtitle
.ShareParams
class.mailToFallbackEnabled
to disable web mailTo failback (enabled by default)downloadFallbackEnabled
is no longer a static setting but part of theShareParams
uri
is now supported on all platforms by sharing the URI as plain textNot a breaking change, since the old API is still compatible, only it has been deprecated.
But we should consider bumping the version of
share_plus
to a major release nevertheless, since the deprecation will break CI/CD lint analysis.TODO:
Related Issues
share_plus
refactor #3403EXTRA_TITLE
in share Intent on Android #3307Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).