Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Platform config fields other than 'endpoint' and 'insecure' cannot be overriden in flyte-cli commands #2614

Closed
2 tasks done
eapolinario opened this issue Jun 14, 2022 · 0 comments
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@eapolinario
Copy link
Contributor

Describe the bug

Plaform config fields like auth mode or client id cannot be overriden via env vars nor config files in flyte-cli commands. The reason behind this is this line, which ends up creating a PlatformConfig object containig default values for all fields but 'endpoint' and 'insecure'.

Expected behavior

The usual methods of replacing config entries (i.e. either relying on env vars or a config file) should apply, regardless of the type of the config being loaded.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue labels Jun 14, 2022
@eapolinario eapolinario self-assigned this Jun 14, 2022
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 14, 2022
@eapolinario eapolinario added this to the 1.1.0 - Hawk milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

1 participant