Fix get client in flyte-cli commands #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…li/main.py Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
=======================================
Coverage 86.50% 86.51%
=======================================
Files 267 268 +1
Lines 24847 24864 +17
Branches 2797 2799 +2
=======================================
+ Hits 21493 21510 +17
Misses 2877 2877
Partials 477 477 ☔ View full report in Codecov by Sentry. |
kumare3
reviewed
Jun 14, 2022
| @@ -276,7 +277,7 @@ def _get_client(host: str, insecure: bool) -> _friendly_client.SynchronousFlyteC | |||
| if parent_ctx.obj["cacert"]: | |||
| kwargs["root_certificates"] = parent_ctx.obj["cacert"] | |||
| cfg = parent_ctx.obj["config"] | |||
| cfg = cfg.with_parameters(endpoint=host, insecure=insecure) | |||
| cfg = replace(cfg, endpoint=host, insecure=insecure) | |||
kumare3
approved these changes
Jun 14, 2022
8 tasks
eapolinario
added a commit
that referenced
this pull request
Jun 17, 2022
* Replace fields of platform_config with dataclasses.replace in flyte-cli/main.py Signed-off-by: Eduardo Apolinario <[email protected]> * Remove with_parameters Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario [email protected]
TL;DR
Fix copy of dataclass in get_client in flyte-cli commands
Type
Are all requirements met?
Complete description
Used
dataclasses.replaceto generate a copy of the PlatformConfig instead of thewith_parameters.Tracking Issue
flyteorg/flyte#2614
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/