-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flytepropeller][flyteidl][flyteconnector][flytagent] Connector Service and Connnector IDL #6325
Open
Future-Outlier
wants to merge
11
commits into
master
Choose a base branch
from
new-proto-agent
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
…ice and Connnector IDL Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run Status
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6325 +/- ##
==========================================
+ Coverage 58.50% 59.46% +0.96%
==========================================
Files 937 553 -384
Lines 71088 37859 -33229
==========================================
- Hits 41587 22514 -19073
+ Misses 26349 13689 -12660
+ Partials 3152 1656 -1496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run Status
|
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run Status
|
Signed-off-by: Kevin Su <[email protected]>
pingsutw
reviewed
Mar 11, 2025
Signed-off-by: Kevin Su <[email protected]>
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
Why are the changes needed?
Given there's a name collision between LLM agent and flyte agent, we are going to rename flyte agent to flyte connectors.
What changes were proposed in this pull request?
agent-service
andconnector-service
now in the same time, propeller will crash because the task type is ambiguous.https://github.com/flyteorg/flyte/blob/new-proto-agent/flytepropeller/pkg/controller/nodes/task/handler.go#L360-L363
How was this patch tested?
new flyte and old flytekit
single binary with this branch and flytekit with master branch at 5/11.
flytekit commit hash: 0214448e96c18ecfcbc050d767be77966f7191fb
connector-service
plugin.agent-service
plugin.Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link