Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller][flyteidl][flyteconnector][flytagent] Connector with a new Service #6332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Future-Outlier
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Connector with a new Service [flytepropeller][flyteidl][flyteconnector][flytagent] Connector with a new Service Mar 12, 2025
@flyte-bot
Copy link
Collaborator

flyte-bot commented Mar 12, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - Bito Code Review Agent didn't review this pull request automatically because it exceeded the size limit. No action is needed if you didn't intend for the agent to review it. Otherwise, you can initiate the review by typing /review in a comment below.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 449 lines in your changes missing coverage. Please review.

Project coverage is 59.37%. Comparing base (7bc47df) to head (e3abc08).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...lugins/go/tasks/plugins/webapi/connector/plugin.go 0.00% 316 Missing ⚠️
...lugins/go/tasks/plugins/webapi/connector/client.go 0.00% 121 Missing ⚠️
...yteplugins/go/tasks/pluginmachinery/core/plugin.go 0.00% 8 Missing ⚠️
...lugins/go/tasks/plugins/webapi/connector/config.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6332      +/-   ##
==========================================
+ Coverage   58.48%   59.37%   +0.88%     
==========================================
  Files         937      719     -218     
  Lines       71091    52078   -19013     
==========================================
- Hits        41580    30919   -10661     
+ Misses      26359    18844    -7515     
+ Partials     3152     2315     -837     
Flag Coverage Δ
unittests-datacatalog 59.06% <ø> (ø)
unittests-flyteadmin 56.30% <ø> (+0.02%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 59.07% <0.00%> (-1.93%) ⬇️
unittests-flytepropeller ?
unittests-flytestdlib 64.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants