-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Event Docs #6334
Update Event Docs #6334
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Code Review Agent Run #768a6dActionable Suggestions - 0Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Signed-off-by: Chris <[email protected]>
d40402e
to
4de2108
Compare
Code Review Agent Run #2fd5deActionable Suggestions - 0Review Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6334 +/- ##
=======================================
Coverage 58.48% 58.49%
=======================================
Files 937 937
Lines 71091 71091
=======================================
+ Hits 41580 41586 +6
+ Misses 26359 26353 -6
Partials 3152 3152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Congrats on merging your first pull request! 🎉 |
Tracking issue
Closes #3663
Why are the changes needed?
Documentation was incorrect. For GCP you need projectId instead of region.
What changes were proposed in this pull request?
Setup correct Helm values for GCP.
How was this patch tested?
Tested in CI. Updated a few lines in docs.
Labels
changed
Setup process
N/A
Screenshots
N/A
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A
Summary by Bito
This PR updates event documentation by fixing configuration parameters and enhancing clarity. It removes outdated AWS examples, introduces a tabbed layout for AWS SNS and GCP Pub/Sub, and correctly uses projectId for GCP instead of region. These changes improve documentation accuracy and usability.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1