Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

Add support for gate nodes #399

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Add support for gate nodes #399

merged 2 commits into from
Mar 14, 2023

Conversation

eapolinario
Copy link
Contributor

Read then delete

  • Make sure to use a concise title for the pull-request.
  • Use #patch, #minor #majora or #none in the pull-request title to bump the corresponding version. Otherwise, the patch version
    will be bumped. More details

TL;DR

Add support for gate nodes

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

handle gate nodes in hydrateNode.

Tracking Issue

flyteorg/flyte#3461

Follow-up issue

NA

Signed-off-by: eduardo apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #399 (90c01cb) into master (e55c649) will increase coverage by 0.78%.
The diff coverage is 100.00%.

❗ Current head 90c01cb differs from pull request most recent head 064700e. Consider uploading reports for the commit 064700e to get more accurate results

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   66.57%   67.35%   +0.78%     
==========================================
  Files         145      145              
  Lines        6270     5235    -1035     
==========================================
- Hits         4174     3526     -648     
+ Misses       1816     1429     -387     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/register/register_util.go 78.25% <100.00%> (+2.37%) ⬆️

... and 133 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: eduardo apolinario <[email protected]>
@eapolinario eapolinario merged commit 29da288 into master Mar 14, 2023
@eapolinario eapolinario deleted the add-support-for-gate-nodes branch March 14, 2023 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants