-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Pydantic V1 plugin #3040
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run #7d0c67Actionable Suggestions - 0Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3040 +/- ##
==========================================
- Coverage 78.61% 76.85% -1.77%
==========================================
Files 288 202 -86
Lines 25120 21357 -3763
Branches 2734 2744 +10
==========================================
- Hits 19749 16414 -3335
+ Misses 4615 4184 -431
- Partials 756 759 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ArthurBook We have Pydantic plugin v2 that supports all the types right now. Mind giving it a try?
hi @pingsutw ! we unfortunately deprecated the component where we were using flyte so I don't have any workloads at hand to try it with... :( |
Signed-off-by: Future-Outlier <[email protected]>
Tracking issue
flyteorg/flyte#5033
Why are the changes needed?
We discourage everyone not to use pydantic v1 plugin.
slack discussion screenshot:

What changes were proposed in this pull request?
Delete pydantic v1 plugin.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR removes the deprecated Pydantic V1 plugin from the Flyte codebase, including all serialization, deserialization, and type transformation logic. The change aims to encourage direct usage of Pydantic V2 with Flytekit tasks. All plugin files, test files, and package configurations have been removed.Unit tests added: False
Estimated effort to review (1-5, lower is better): 3