Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate baseline #3090

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Regenerate baseline #3090

merged 1 commit into from
Jan 25, 2025

Conversation

eapolinario
Copy link
Collaborator

Why are the changes needed?

Last baseline pydoclint file didn't contain this change to ImageSpec.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@eapolinario
Regenerate baseline
a651065 
Signed-off-by: Eduardo Apolinario <[email protected]>
@flyte-bot
Copy link
Contributor

flyte-bot commented Jan 25, 2025 •
edited
Loading

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - We encountered technical difficulties while attempting to generate code feedback. Please try again or contact [email protected].

@eapolinario eapolinario enabled auto-merge (squash) January 25, 2025 01:19
@eapolinario eapolinario disabled auto-merge January 25, 2025 01:20
@eapolinario eapolinario enabled auto-merge (squash) January 25, 2025 01:22
@eapolinario eapolinario mentioned this pull request Jan 25, 2025
Merged
3 tasks
@eapolinario eapolinario merged commit b61436b into master Jan 25, 2025
108 of 110 checks passed
ChihTsungLu pushed a commit to ChihTsungLu/flytekit that referenced this pull request Jan 27, 2025
@eapolinario @ChihTsungLu
Regenerate baseline (flyteorg#3090)
8b5f1f2 
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: lu00122 <[email protected]>
@thomasjpfan thomasjpfan mentioned this pull request Feb 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

@pingsutw pingsutw pingsutw approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eapolinario @flyte-bot @wild-endeavor @pingsutw