Gatenode local execution, was parsing the input twice

[kumare3]

For example like so,

import flytekit as fl
from dataclasses import dataclass
from datetime import timedelta

dt = timedelta(seconds=60)

@dataclass
class MyClass:
  x: int
  y: str


@fl.task
def my_task(c: MyClass) -> MyClass:
   return c


@fl.workflow
def my_wf():
  c = fl.wait_for_input("tst", dt, MyClass)
  my_task(c=c)

Local execution will result in failure

Failed to parse input: stat: path should be string, bytes, os.PathLike or integer, not MyClass

This fixes the local execution. Remote works fine!

Summary by Bito

Fixed a bug in local execution where input parsing was being performed twice for gatenode interactions. The change simplifies input parsing by removing redundant type conversion in parse_stdin.py, improving handling of complex types like custom dataclasses during local workflow execution while maintaining remote execution behavior.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

[flyte-bot]

Code Review Agent Run #a13ba8

Actionable Suggestions - 1

• flytekit/interaction/parse_stdin.py - 1

  • Consider implications of removing click validation · Line 31-31

Review Details

• Files reviewed - 1 · Commit Range: f170325..f170325

  • flytekit/interaction/parse_stdin.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Bug Fix - Fix Input Parsing for Local Execution	- parse_stdin.py - Simplified input parsing by removing redundant type conversion for local execution

[flyte-bot]

Consider implications of removing click validation

Consider if the direct conversion of user_input to literal is safe without the intermediate click type conversion. The removed click type validation could have been providing important input validation.

Code suggestion

Check the AI-generated fix before applying

Suggested change

	return TypeEngine.to_literal(FlyteContext.current_context(), user_input, t, lt)
	option = click.Option(["--input"], type=literal_converter.click_type)
	validated_input = literal_converter.click_type.convert(user_input, option, click.Context(command=click.Command("")))
	return TypeEngine.to_literal(FlyteContext.current_context(), validated_input, t, lt)

Code Review Run #a13ba8

---

Is this a valid issue, or was it incorrectly flagged by the Agent?

• it was incorrectly flagged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (4208a64) to head (f170325).
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3101       +/-   ##
===========================================
+ Coverage   51.81%   77.91%   +26.09%     
===========================================
  Files         202      202               
  Lines       21469    21470        +1     
  Branches     2766     2767        +1     
===========================================
+ Hits        11125    16728     +5603     
+ Misses       9735     3943     -5792     
- Partials      609      799      +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Future-Outlier]

import flytekit as fl
from dataclasses import dataclass
from datetime import timedelta
from pydantic import BaseModel

dt = timedelta(seconds=60)

class MyClass(BaseModel):
  x: int
  y: str


@fl.task
def my_task(c: MyClass) -> MyClass:
   return c


@fl.workflow
def my_wf():
  c = fl.wait_for_input("tst", dt, MyClass)
  my_task(c=c)

(flyte-dev) future@outlier ~ % pyflyte run build/PR/pr_ketan_gatenode.py my_wf
10:42:38.994067 INFO     file.py:252 - Using flytectl/YAML config /Users/future-outlier/.flyte/config-sandbox.yaml                   
Running Execution on local.
[Input Gate] Waiting for input @tst of type <class 'pr_ketan_gatenode.MyClass'>: {"x":1, "y":"2"}
10:42:43.650104 INFO     utils.py:344 - AsyncTranslate literal to python value. [Time: 0.000003s]                                    
10:42:43.650933 INFO     utils.py:344 - Translate literal to python value. [Time: 0.000845s]                                         
10:42:43.651410 INFO     base_task.py:749 - Invoking pr_ketan_gatenode.my_task with inputs: {'c': MyClass(x=1, y='2')}               
10:42:43.651826 INFO     utils.py:344 - Execute user level code. [Time: 0.000006s]                                                   
10:42:43.652375 INFO     utils.py:344 - Translate the output to literals. [Time: 0.000146s]                                          
10:42:43.652871 INFO     utils.py:344 - dispatch execute. [Time: 0.000726s]