Compile byte code during ImageSpec install #3175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR adds byte code compiling to the image spec, which reduces runtime at the cost of a slightly bigger image. With this simple workflow:
I got these runtimes:
What changes were proposed in this pull request?
Adds
UV_COMPILE_BYTECODE=1
to the image builder.How was this patch tested?
I ran the workflow above and benchmarked the times.
Summary by Bito
This PR introduces bytecode compilation to the ImageSpec installation process by adding the UV_COMPILE_BYTECODE flag in the image builder file. The modification optimizes image build configuration as shown by benchmarks, enhancing functionality while remaining straightforward and testable.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1