Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: select completion with comma key #2871

Closed
fonsp opened this issue Mar 29, 2024 · 9 comments
Closed

Autocomplete: select completion with comma key #2871

fonsp opened this issue Mar 29, 2024 · 9 comments
Labels
autocomplete <TAB> frontend Concerning the HTML editor

Comments

@fonsp
Copy link
Owner

fonsp commented Mar 29, 2024

Typing funcs = [sin, identi<COMMA> should autocomplete to funcs = [sin, identity,

@fonsp fonsp added the frontend Concerning the HTML editor label Mar 29, 2024
@fonsp
Copy link
Owner Author

fonsp commented Mar 29, 2024

Same with (

@fonsp fonsp closed this as completed in 62baa88 Mar 29, 2024
@fonsp fonsp added the autocomplete <TAB> label Mar 29, 2024
@kosukesando
Copy link

I'm having trouble with this behaviour being overzealous, for example when I just want to iterate over zip'd iterables:

for (f,b) in zip(foo,bar)

typing in for (f<COMMA> will instantly autocomplete this with some arbitrary variable that has nothing to do with this code block.
I think there's been other occurrences of this but can't give off the top of my head right now.

@kosukesando
Copy link

kosukesando commented May 23, 2024

It's also doubly annoying when I can't ESC out of the autocomplete back to the cell, but it takes me out of the autocomplete AND the cell. (please excuse the double comment, it probably belongs somewhere else)

@fonsp
Copy link
Owner Author

fonsp commented May 23, 2024

Thanks! What browser do you use?

@kosukesando
Copy link

Firefox(126.0) on Windows 10, running Julia+Pluto on Ubuntu(WSL2).

@fonsp
Copy link
Owner Author

fonsp commented May 23, 2024

Can you check if the ESC issue also exists on Chrome if you have it installed?

fonsp added a commit that referenced this issue May 23, 2024
@fonsp
Copy link
Owner Author

fonsp commented May 23, 2024

Fixed the comma thing in 3af53f9

@fonsp
Copy link
Owner Author

fonsp commented May 23, 2024

Can you check if the ESC issue is also there on Pluto#main? I can't reproduce on firefox. If so, could you make a new issue?

@kosukesando
Copy link

Thanks for the quick response!
I tried Chrome, it turns out the ESC issue was just Vimium, my bad. The comma thing was present in both FF and Chrome.
For the time being I can just deal with the autocomplete with hitting ESC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete <TAB> frontend Concerning the HTML editor
Projects
None yet
Development

No branches or pull requests

2 participants