local variable autocomplete

[Pangoraw]

This collects all local variables in a new scopestate field along with their "validity" range (range in which they are valid). Can be used for autocompletion of local variable and enhanced linting in #1859 (also potentially renaming of variables). @dralletje, what do you think about this approach ? (lezer-matcher is insane btw 🤯)

[github-actions]

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="autocomplete_locals")
julia> using Pluto

[dralletje]

Nice :)

Anything specific for it to be a draft? Apart from a console.log it looks good to me.

[Pangoraw]

i would like to fix this before merging:

Pluto.jl/frontend/components/CellInput/scopestate_statefield.js

Lines 379 to 381 in 2e02b82

	// FIXME: Using definition.to is not quite right here, because the
	// name is not valid until the assignment expression is done and will
	// currently be autocompleted on the right hand side of its own assignment :'(

[Pangoraw]

Should be good to go!

[fonsp]

Awesome!

I noticed one issue: if I autocomplete s with a local var that starts with s, it selects that one immediately.

My guess is that the real Julia autocomplete is taking too long in this case (lots of options with s), and the autocomplete window pops up with just the sqrt2, which immediately triggers.

Schermopname.2022-03-21.om.14.00.10.mov

[fonsp]

Fixed!

Schermopname.2022-03-21.om.14.07.43.mov

[fonsp]

@dralletje pointed out that this has a big performance impact because it makes raise_scope slower, and that function is already a bottleneck. Since I already merged this, we might need to uncomment some this feature on main while we work on performance :(

[fonsp]

Enabled again in #3151