workspace_custom_startup_expr as String #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="workspace_custom_startup_expr-String")
julia> using Pluto |
Pangoraw
reviewed
Sep 20, 2023
rikhuijzer
approved these changes
Sep 20, 2023
|
I do wonder whether this actually fixes the situation from #2652? Maybe this just needed better documentation? |
Co-authored-by: Paul Berg <[email protected]>
|
It does fix #2652, Paul found out the cause here #2653 (comment) |
|
Ah if PlutoStaticHTML is version-pinned then let's just change it without a compat :) |
rikhuijzer
added a commit
to rikhuijzer/PlutoStaticHTML.jl
that referenced
this pull request
Sep 26, 2023
Contains fix for fonsp/Pluto.jl#2654.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2652
This change is breaking:
session.options.evaluation.workspace_custom_startup_exprnow needs to be aString, not anExpr. We believe that this is not too bad since the setting used to be broken (#2652), unless you used Pluto without a web client or built-in HTML export, which is quite rare and probably only happens in PlutoStaticHTML.jl, which uses a version-pinned Pluto dependency.